Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Kenyan holidays #69

Merged
merged 4 commits into from
Jan 27, 2024
Merged

Conversation

PhilN8
Copy link
Contributor

@PhilN8 PhilN8 commented Jan 18, 2024

Adds Kenya's recognized holidays

Note

The holidays of Idd-ul-Fitr, Idd-ul-Azha and Diwali are based on the appearance of the moon, hence not added

@PhilN8 PhilN8 changed the title Feat: Kenyan holidays added Added Kenyan holidays Jan 18, 2024
@PhilN8 PhilN8 closed this Jan 18, 2024
@PhilN8 PhilN8 reopened this Jan 18, 2024
@PhilN8 PhilN8 closed this Jan 18, 2024
@PhilN8 PhilN8 reopened this Jan 18, 2024
@Nielsvanpach
Copy link
Member

Thanks! Can you rebase from main, so I can run the tests here?

@PhilN8 PhilN8 force-pushed the feat-kenya-holidays branch from 9fcc0f7 to b678d6c Compare January 18, 2024 15:47
@PhilN8
Copy link
Contributor Author

PhilN8 commented Jan 18, 2024

Thanks for the ping, @Nielsvanpach. It has been successfully rebased.

@PhilN8
Copy link
Contributor Author

PhilN8 commented Jan 18, 2024

Fixed PHPStan errors

@PhilN8
Copy link
Contributor Author

PhilN8 commented Jan 18, 2024

Edited out the buggy line, now I think all tests pass

@Nielsvanpach
Copy link
Member

Thanks!

@Nielsvanpach Nielsvanpach merged commit 0ed8208 into spatie:main Jan 27, 2024
12 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants